Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

feat(nitro): add nitro:build:before hook #4304

Merged
pi0 merged 9 commits into from
May 2, 2022
Merged

feat(nitro): add nitro:build:before hook #4304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
199d446
fix(nitro): add back `nitro:generate` hook
danielroe Apr 12, 2022
0fb4996
Merge branch 'main' into fix/nitro-generate-hook
danielroe May 1, 2022
6a99ca3
fix: use `nitro:generate` hook for vite workarounds
danielroe May 1, 2022
0f20a9c
fix: remove comment
danielroe May 1, 2022
6c79509
fix: only call `nitro:generate` in build mode
danielroe May 2, 2022
07bb181
Merge remote-tracking branch 'origin/main' into fix/nitro-generate-hook
danielroe May 2, 2022
792993c
rename hook to `nitro:_build`
pi0 May 2, 2022
76f8235
fix: use `nitro:build:before`
danielroe May 2, 2022
23898bf
move dev guard
pi0 May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/nuxt/src/core/nitro.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ export async function initNitro (nuxt: Nuxt) {

// nuxt build/dev
nuxt.hook('build:done', async () => {
await nuxt.callHook('nitro:build:before', nitro)
if (nuxt.options.dev) {
Comment thread
danielroe marked this conversation as resolved.
await build(nitro)
} else {
Expand Down
1 change: 1 addition & 0 deletions packages/schema/src/types/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ export interface NuxtHooks {
// nitropack
'nitro:config': (nitroConfig: NitroConfig) => HookResult
'nitro:init': (nitro: Nitro) => HookResult
'nitro:build:before': (nitro: Nitro) => HookResult

// @nuxt/cli
'generate:cache:ignore': (ignore: string[]) => HookResult
Expand Down
6 changes: 4 additions & 2 deletions packages/vite/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,10 @@ export async function buildServer (ctx: ViteBuildContext) {

await ctx.nuxt.callHook('vite:extendConfig', serverConfig, { isClient: false, isServer: true })

// TODO: Do we still need this?
ctx.nuxt.hook('build:done', async () => {
ctx.nuxt.hook('nitro:build:before', async () => {
if (ctx.nuxt.options.dev) {
return
}
const clientDist = resolve(ctx.nuxt.options.buildDir, 'dist/client')

// Remove public files that have been duplicated into buildAssetsDir
Expand Down