Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt3): allow separating client and server components#4390

Merged
pi0 merged 8 commits intomainfrom
feat/client-and-server-components
Apr 19, 2022
Merged

feat(nuxt3): allow separating client and server components#4390
pi0 merged 8 commits intomainfrom
feat/client-and-server-components

Conversation

@danielroe
Copy link
Copy Markdown
Member

@danielroe danielroe commented Apr 15, 2022

🔗 Linked issue

nuxt/nuxt#11884, follow up on #1919

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR largely takes @antfu's code but slightly simplifies the scanning/loading implementation. There may be oversights - review welcome!

📝 Checklist

  • I have linked an issue or discussion.
  • update #build/components import to work in client/server mode
  • consider component name ending with Server/Client for clarity in Dev tools, etc.
  • I have updated the documentation accordingly.

Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
@danielroe danielroe added enhancement New feature or request nuxt3 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Apr 15, 2022
@danielroe danielroe requested a review from pi0 April 15, 2022 23:54
@danielroe danielroe self-assigned this Apr 15, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 15, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 32a6dfe
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/625acd0da925540009496842

@danielroe danielroe marked this pull request as ready for review April 16, 2022 07:08
@misaon
Copy link
Copy Markdown
Contributor

misaon commented Apr 16, 2022

Perfect ♥️

@danielroe danielroe requested a review from antfu April 16, 2022 20:13
@pi0 pi0 merged commit b38dc09 into main Apr 19, 2022
@pi0 pi0 deleted the feat/client-and-server-components branch April 19, 2022 19:13
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x enhancement New feature or request nuxt3 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants