Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

docs(config): correct naming of NUXT_APP_CDN_URL environment variable#5032

Merged
pi0 merged 1 commit intonuxt:mainfrom
srtonz:patch-1
May 20, 2022
Merged

docs(config): correct naming of NUXT_APP_CDN_URL environment variable#5032
pi0 merged 1 commit intonuxt:mainfrom
srtonz:patch-1

Conversation

@srtonz
Copy link
Copy Markdown
Contributor

@srtonz srtonz commented May 18, 2022

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When setting up CDN configuration Nuxt parses the value of NUXT_APP_CDN_URL, but documentation is incorrectly showing the variable as CDN_URL.

$resolve: (val, get) => get('dev') ? '' : (process.env.NUXT_APP_CDN_URL ?? val) || ''

📝 Checklist

  • I have linked an issue or discussion.

If you spot an area where we can improve documentation or error messages, please do open a PR - even if it's just to fix a typo!

Implies no issue required.

  • I have updated the documentation accordingly.

Updates docstring to show correct name for the NUXT_APP_CDN_URL variable.
@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 68db244
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62847a4b2bc282000893aa96

@pi0 pi0 changed the title docs: correct naming of NUXT_APP_CDN_URL docs(config): correct naming of NUXT_APP_CDN_URL environment variable May 20, 2022
Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit ca526cf into nuxt:main May 20, 2022
@pi0 pi0 mentioned this pull request Jun 10, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants