Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): respect navigateTo options using server middleware in server-side#5145

Merged
pi0 merged 2 commits intomainfrom
fix/navigate-middleware-server
May 31, 2022
Merged

fix(nuxt): respect navigateTo options using server middleware in server-side#5145
pi0 merged 2 commits intomainfrom
fix/navigate-middleware-server

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#13993

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

On SSR we can directly redirect within middleware when user calls navigateTo, which will also mean we can respect the user's options.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels May 25, 2022
@danielroe danielroe requested a review from pi0 May 25, 2022 15:15
@danielroe danielroe self-assigned this May 25, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented May 25, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 3ac3e6b
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/629691727fc8bb0008218e5d
😎 Deploy Preview https://deploy-preview-5145--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Comment thread packages/nuxt/src/app/composables/router.ts
Co-authored-by: pooya parsa <pyapar@gmail.com>
@pi0 pi0 changed the title fix(nuxt): respect navigateTo options on SSR mw fix(nuxt): respect navigateTo options using server middleware in server-side May 31, 2022
@pi0 pi0 merged commit 1fda732 into main May 31, 2022
@pi0 pi0 deleted the fix/navigate-middleware-server branch May 31, 2022 22:09
@pi0 pi0 mentioned this pull request Jun 10, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants