Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

docs(examples): rename hello.ts to [...hello].ts#5261

Merged
pi0 merged 4 commits intonuxt:mainfrom
qin-guan:patch-1
Jun 22, 2022
Merged

docs(examples): rename hello.ts to [...hello].ts#5261
pi0 merged 4 commits intonuxt:mainfrom
qin-guan:patch-1

Conversation

@qin-guan
Copy link
Copy Markdown
Contributor

@qin-guan qin-guan commented Jun 2, 2022

🔗 Linked issue

nuxt/nuxt#14077

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fixes a bad server route in useFetch example

Resolves nuxt/nuxt#14077

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 2, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit e273b38
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62b3506d258ecd0008468223

@danielroe danielroe changed the title fix(examples): rename hello.ts to [...hello].ts docs(examples): rename hello.ts to [...hello].ts Jun 3, 2022
@pi0
Copy link
Copy Markdown
Member

pi0 commented Jun 3, 2022

Thanks for this PR @qin-guan 💚 It seems working an good fix. Since we are now using named route params, we can also replace parseURL().pathname (here) to event.context.params.id.

@qin-guan
Copy link
Copy Markdown
Contributor Author

qin-guan commented Jun 3, 2022

I see, thanks for the feedback! I will update the PR :)

@qin-guan
Copy link
Copy Markdown
Contributor Author

Hey @pi0, sorry for the late update, 😔 PTAL

Comment thread examples/composables/use-fetch/server/api/[...hello].ts Outdated
@pi0 pi0 merged commit 2156079 into nuxt:main Jun 22, 2022
@pi0
Copy link
Copy Markdown
Member

pi0 commented Jun 22, 2022

Thanks for working on this!

@qin-guan
Copy link
Copy Markdown
Contributor Author

Thanks for this first PR opportunity, and for all the work y'all are doing with Nuxt, truly amazing! 🙌🏻 🙏🏻

@pi0 pi0 mentioned this pull request Jul 11, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useFetch example in documentation is broken

3 participants