Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(webpack): write stub server file with ssr: false#5372

Closed
danielroe wants to merge 1 commit intomainfrom
fix/webpack-spa
Closed

fix(webpack): write stub server file with ssr: false#5372
danielroe wants to merge 1 commit intomainfrom
fix/webpack-spa

Conversation

@danielroe
Copy link
Copy Markdown
Member

@danielroe danielroe commented Jun 9, 2022

🔗 Linked issue

resolves nuxt/nuxt#13986

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Rollup needs to resolve #build/dist/server/server.mjs even though it will never be used/imported (src). This PR ensures the stub is present in webpack, just as it is in vite.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working webpack ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Jun 9, 2022
@danielroe danielroe requested a review from pi0 June 9, 2022 13:48
@danielroe danielroe self-assigned this Jun 9, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 9, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 9fe00d6
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62a1fa45810d8300080c9030

@pi0 pi0 added the pending label Jun 9, 2022
@florian-lefebvre
Copy link
Copy Markdown
Contributor

florian-lefebvre commented Jun 9, 2022

What about vite?

@danielroe
Copy link
Copy Markdown
Member Author

danielroe commented Jun 9, 2022

@florian-lefebvre Are you experiencing an issue with vite? Do you have a link to an issue?

@florian-lefebvre
Copy link
Copy Markdown
Contributor

florian-lefebvre commented Jun 9, 2022

Yes, looks like nuxt/nuxt#14114 is the same for vite

@pi0
Copy link
Copy Markdown
Member

pi0 commented Jun 10, 2022

I think have a better universal solution for this using nitro. That's why put pending :)

@danielroe danielroe mentioned this pull request Jul 6, 2022
Closed
7 tasks
@pi0
Copy link
Copy Markdown
Member

pi0 commented Jul 7, 2022

Moving to #5773 using virtual imports.

@pi0 pi0 closed this Jul 7, 2022
@pi0 pi0 deleted the fix/webpack-spa branch July 7, 2022 16:46
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pi0 pi0 Awaiting requested review from pi0

1 more reviewer

@bachilli bachilli bachilli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danielroe danielroe

Labels

3.x bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf pending webpack

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Could not load .nuxt/dist/server/server.mjs when using ssr false and webpack

4 participants

@danielroe @florian-lefebvre @pi0 @bachilli