This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxi): build all types on typecheck command#5437
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
cawa-93
changed the title
|
I think we can merge this PR |
pi0
approved these changes
Aug 23, 2022
Member
There was a problem hiding this comment.
Thanks <3 LGTM waiting for @danielroe to double check.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
fix: nuxt/nuxt#12845
❓ Type of change
📚 Description
The
writeTypesmethod only createsnuxt.d.tsandtypes/nitro.d.ts, ignoring plugins types, components, autoimport, composables and so on. As a result, type checking fails with false positives errors.The easiest way to generate all types is to call the
buildNuxtmethod with the_prepare: trueoption for better performance📝 Checklist