This repository was archived by the owner on Apr 6, 2023. It is now read-only.
Conversation
danielroe
added
bug
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
approved these changes
Jun 20, 2022
Member
pi0
left a comment
pi0
left a comment
There was a problem hiding this comment.
Nice find! Should we also apply for other options such as watch?
pi0
reviewed
Jun 20, 2022
| port: hmrPort | ||
| }, | ||
| watch: nuxt.options.dev ? { ignored: isIgnored } : {}, | ||
| hmr: nuxt.options.dev |
Member
There was a problem hiding this comment.
Refactor suggestion: What if after constructing initial object, we directly nullify some dev-only options like ctx.config.server.watch = false. This way we can make code simpler with less inline ? condition and also add a clear comment above why we are doing this.
pi0
approved these changes
Jun 20, 2022
antfu
approved these changes
Jun 21, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/nuxt#14057
❓ Type of change
📚 Description
Vite tests whether hmr is truthy in deciding whether to inject certain code. We should disable this in build mode as a matter of best practice, although there shouldn't be any active bugs as we are now overriding NODE_ENV.
📝 Checklist