Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

feat(kit): add addLayout#5537

Merged
pi0 merged 6 commits intomainfrom
fix/kit-add-layout
Jun 27, 2022
Merged

feat(kit): add addLayout#5537
pi0 merged 6 commits intomainfrom
fix/kit-add-layout

Conversation

@danielroe
Copy link
Copy Markdown
Member

@danielroe danielroe commented Jun 20, 2022

🔗 Linked issue

❓ Type of change

resolves nuxt/nuxt#14181

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds a Nuxt 3 implementation for this.addLayout and also exports it as a standalone util. Happy to go in the other direction and reconsider the standalone utility (or even deprecate the module container util), but if we have it, we might as well make it available and working on nuxt 3.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the kit label Jun 20, 2022
@danielroe danielroe requested a review from pi0 June 20, 2022 15:48
@danielroe danielroe self-assigned this Jun 20, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 20, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit c39dcc2
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62b3554be4f1d30009a10804
😎 Deploy Preview https://deploy-preview-5537--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0
Copy link
Copy Markdown
Member

pi0 commented Jun 20, 2022

I think this PR is introducing a new feature :)

Comment thread packages/kit/src/layout.ts Outdated
Comment thread packages/kit/src/layout.ts Outdated
Comment thread packages/kit/src/layout.ts
@pi0 pi0 changed the title fix(kit): add nuxt 3 implementation for addLayout and separate util feat(kit): add addLayout Jun 20, 2022
@danielroe danielroe force-pushed the fix/kit-add-layout branch from 4c281b4 to b5856aa Compare June 21, 2022 13:33
@danielroe danielroe added the enhancement New feature or request label Jun 21, 2022
Comment thread packages/kit/src/layout.ts Outdated
Comment thread packages/kit/src/layout.ts Outdated
Comment thread packages/kit/src/layout.ts
@pi0 pi0 merged commit 6f8b7a9 into main Jun 27, 2022
@pi0 pi0 deleted the fix/kit-add-layout branch June 27, 2022 11:47
@sppmstar
Copy link
Copy Markdown

when will this update be published ?

@atinux
Copy link
Copy Markdown
Member

atinux commented Jun 27, 2022

You can already play with it using the edge channel @sppmstar : https://v3.nuxtjs.org/guide/going-further/edge-channel

@sppmstar
Copy link
Copy Markdown

@atinux I have a nuxt module generated by nuxi. I tried the edge channel approach documented in the link you shared with me, but when i run yarn why @nuxt/kit i still see rc4 version being installed, which does not include the addLayout helper i need :(

@atinux
Copy link
Copy Markdown
Member

atinux commented Jun 29, 2022

Can you try with:

"@nuxt/kit": "npm:@nuxt/kit-edge@latest"

@sppmstar
Copy link
Copy Markdown

That worked! thanks a lot :)

@pi0 pi0 mentioned this pull request Jul 11, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x enhancement New feature or request kit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

moduleContainer addlayout not working

4 participants