Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): pass attrs and props to client-only components#5668

Merged
pi0 merged 3 commits intomainfrom
fix/client-only-attrs
Jun 30, 2022
Merged

fix(nuxt): pass attrs and props to client-only components#5668
pi0 merged 3 commits intomainfrom
fix/client-only-attrs

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently props for a client-only component (e.g. ~/components/SomeComp.client.vue) aren't getting passed properly, because the Vue 2 signature was being used.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jun 30, 2022
@danielroe danielroe requested a review from pi0 June 30, 2022 10:40
@danielroe danielroe self-assigned this Jun 30, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 30, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 7992505
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62bd7dafbcf521000803ecb4

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 30, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 68e1ee1
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62bd7e1d3e62c1000871d654

@danielroe danielroe changed the title fix(nuxt): pass attrs directly to client-only and display component name fix(nuxt): pass attrs/props to client-only components Jun 30, 2022
@pi0 pi0 changed the title fix(nuxt): pass attrs/props to client-only components fix(nuxt): pass attrs and props to client-only components Jun 30, 2022
@pi0 pi0 merged commit fe508f5 into main Jun 30, 2022
@pi0 pi0 deleted the fix/client-only-attrs branch June 30, 2022 14:08
@pi0 pi0 mentioned this pull request Jul 11, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants