Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(kit): support adding server-only/client-only components separately#5686

Merged
pi0 merged 1 commit intomainfrom
fix/component-modes
Jul 1, 2022
Merged

fix(kit): support adding server-only/client-only components separately#5686
pi0 merged 1 commit intomainfrom
fix/component-modes

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We currently support client-only components (and differing implementations for client & server), but the built-in addComponent utility doesn't handle this possibility.

This PR allows us to inject separate Server + Client implementations of a component.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jul 1, 2022
@danielroe danielroe requested a review from pi0 July 1, 2022 09:58
@danielroe danielroe self-assigned this Jul 1, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 1, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 86f466d
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62bec556c21b8c00094a8915

@pi0 pi0 merged commit a41644e into main Jul 1, 2022
@pi0 pi0 deleted the fix/component-modes branch July 1, 2022 10:02
@pi0 pi0 mentioned this pull request Jul 11, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants