Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): don't return stub function from tree-shaken composables#5786

Merged
pi0 merged 1 commit intomainfrom
fix/composable-shake
Jul 8, 2022
Merged

fix(nuxt): don't return stub function from tree-shaken composables#5786
pi0 merged 1 commit intomainfrom
fix/composable-shake

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fixes a bug introduced in composable tree-shaking regexp. Also implemented in #5750 but if that's pending we should merge this hotfix sooner.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jul 8, 2022
@danielroe danielroe requested a review from pi0 July 8, 2022 12:24
@danielroe danielroe self-assigned this Jul 8, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 8, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 92349b2
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62c821f3510ab40008addedf

@danielroe danielroe changed the title fix: tree-shake fix fix(nuxt): don't return stub function from tree-shaken composables Jul 8, 2022
@pi0 pi0 merged commit b045b71 into main Jul 8, 2022
@pi0 pi0 deleted the fix/composable-shake branch July 8, 2022 12:42
@pi0 pi0 mentioned this pull request Jul 11, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants