Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): warn about legacy and invalid plugins#5857

Merged
pi0 merged 9 commits intomainfrom
fix/support-second-arg
Jul 12, 2022
Merged

fix(nuxt): warn about legacy and invalid plugins#5857
pi0 merged 9 commits intomainfrom
fix/support-second-arg

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Following #5630, plugins which take a second argument for inject will silently fail. This at least adds a warning if they are being used. Example: https://github.com/moritzsternemann/vue-plausible/blob/main/src/nuxt-plugin.ts (hotfix PR).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jul 12, 2022
@danielroe danielroe requested a review from pi0 July 12, 2022 14:22
@danielroe danielroe self-assigned this Jul 12, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 12, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit d8c939c
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62cda9b46264050009ac97a7

Comment thread packages/nuxt/src/app/nuxt.ts Outdated
@pi0 pi0 changed the title fix(nuxt): pass provide as second argument for legacy plugins fix(nuxt): skip legacy plugins with warning Jul 12, 2022
@pi0 pi0 changed the title fix(nuxt): skip legacy plugins with warning fix(nuxt): warn about legacy and invalid plugins Jul 12, 2022
@pi0 pi0 merged commit 1ced224 into main Jul 12, 2022
@pi0 pi0 deleted the fix/support-second-arg branch July 12, 2022 17:06
@pi0 pi0 mentioned this pull request Jul 12, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants