Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): fix issues with vue-router and @vue/devtools-api bundling#5874

Merged
pi0 merged 3 commits intomainfrom
fix/devtools-mock
Jul 13, 2022
Merged

fix(nuxt): fix issues with vue-router and @vue/devtools-api bundling#5874
pi0 merged 3 commits intomainfrom
fix/devtools-mock

Conversation

@pi0
Copy link
Copy Markdown
Member

@pi0 pi0 commented Jul 13, 2022

🔗 Linked issue

Resolves nuxt/nuxt#13743

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Rollup build fails with ESM proxy mocks. Using cjs entry allows ESM syntax import.
  • Updated nitro to respect development and production export conditions used by latest vue-router

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 13, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 2a3ac04
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62ceb756eaf2480009be788b

@danielroe danielroe mentioned this pull request Jul 13, 2022
7 tasks
@pi0 pi0 marked this pull request as draft July 13, 2022 10:41
@pi0 pi0 changed the title fix(nitro): use cjs proxy for @vue/devtools-api fix(nuxt): fix issues with vue-router and @vue/devtools-api bundling Jul 13, 2022
@pi0 pi0 marked this pull request as ready for review July 13, 2022 12:05
@pi0 pi0 merged commit 0ef0819 into main Jul 13, 2022
@pi0 pi0 deleted the fix/devtools-mock branch July 13, 2022 12:42
@pi0 pi0 mentioned this pull request Jul 13, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'setupDevtoolsPlugin' is not exported by unenv

2 participants