Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

feat: add immediate option to data fetching composables#6044

Closed
DamianGlowala wants to merge 2 commits intonuxt:mainfrom
DamianGlowala:main
Closed

feat: add immediate option to data fetching composables#6044
DamianGlowala wants to merge 2 commits intonuxt:mainfrom
DamianGlowala:main

Conversation

@DamianGlowala
Copy link
Copy Markdown
Member

🔗 Linked issue

Resolves nuxt/nuxt#14333

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I have created this PR to provide a starting point for adding an immediate option to data fetching composables. Checking the logic and adding test cases (if desirable) would be very much appreciated! 🚀

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 21, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 1feb595
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62d99349a15beb000af0b2bd
😎 Deploy Preview https://deploy-preview-6044--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0
Copy link
Copy Markdown
Member

pi0 commented Jul 21, 2022

Thanks for PR. I think we have already another #5500 with same goal. Please check my comment in there #5500 (comment). Probably introducing such composable makes sense to be with new name since usage is for user action.

@DamianGlowala
Copy link
Copy Markdown
Member Author

Ah, didn't notice there's already one :) I'll have a look and do my best to leave some meaningful remarks about the points you raised.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow preventing useFetch/useAsyncData from firing immediately

3 participants