Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

feat(vite-node): clear console when rendering error get fixed #6281

Closed
antfu wants to merge 2 commits into from
Closed

feat(vite-node): clear console when rendering error get fixed #6281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0493122
feat(vite-node): display render message on error fix
antfu Aug 1, 2022
5a8e9d1
Merge branch 'main' into feat/vite-node-render
pi0 Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/vite/src/runtime/vite-node.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { ViteNodeRunner } from 'vite-node/client'
import { $fetch } from 'ohmyfetch'
import consola from 'consola'
import { getViteNodeOptions } from './vite-node-shared.mjs'

const viteNodeOptions = getViteNodeOptions()
Expand All @@ -15,6 +16,7 @@ const runner = new ViteNodeRunner({
})

let render
let previousError = null

export default async (ssrContext) => {
// Workaround for stub mode
Expand All @@ -28,5 +30,12 @@ export default async (ssrContext) => {
runner.moduleCache.delete(key)
}
}
if (ssrContext.error) {
previousError = ssrContext.error
} else if (previousError) {
previousError = null
consola.clear()
Copy link
Copy Markdown
Member

@pi0 pi0 Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't works to clear screen. consola.clear was legacy name for consola. removeReporter.

Also we probably shouldn't clear screen from runtime.

consola.success('Rendered ' + ssrContext.url)
}
return result
}