This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite, nuxt): resolve relative to srcDir rather than rootDir#6546
Merged
fix(vite, nuxt): resolve relative to srcDir rather than rootDir#6546
srcDir rather than rootDir#6546Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
antfu
reviewed
Aug 12, 2022
pi0
approved these changes
Aug 12, 2022
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
pi0
reviewed
Aug 12, 2022
pi0
changed the title
srcDir rather than rootDirsrcDir rather than rootDir
pi0
changed the title
srcDir rather than rootDirsrcDir rather than rootDir
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
With a custom
srcDir, various things were not working, including scanning of new components.This also makes a couple of changes to vite-node, to match the non-vite node implementation where
rootis set tosrcDirand notrootDirbut would value @antfu's verdict on these.📝 Checklist