Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(types): lock rollup to 2.77#6617

Closed
antfu wants to merge 1 commit intomainfrom
chore/downgrade-rollup
Closed

fix(types): lock rollup to 2.77#6617
antfu wants to merge 1 commit intomainfrom
chore/downgrade-rollup

Conversation

@antfu
Copy link
Copy Markdown
Member

@antfu antfu commented Aug 15, 2022

See rollup/rollup#4600 (comment)

Vite locked Rollup to below v2.77 due to type misalignment and planned to upgrade to Rollup 2.78 in Vite 3.1 with vitejs/vite#9634

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 15, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit af8e9f3
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62f9c62717f2ec00083c2de5

@danielroe danielroe changed the title chore: lock rollup to 2.77 fix(types): lock rollup to 2.77 Aug 15, 2022
@pi0
Copy link
Copy Markdown
Member

pi0 commented Aug 15, 2022

This is an upstream issue. I wish rollup or vite dependencies could handle type-breaking changes in semver-minor upgrades or at least we manage to upgrade to vite 3.1 until Next RC.

Type issues should be resolved (at least for monorepo) by 09781a5 and e109d65 handled by yarn. New lockfile:

yarn why rollup
├─ @nuxt/vite-builder@workspace:packages/vite [efbe9]
│  └─ rollup@npm:2.78.0 (via npm:^2.78.0)
│
├─ @nuxt/vite-builder@workspace:packages/vite
│  └─ rollup@npm:2.78.0 (via npm:^2.78.0)
│
├─ nitropack@npm:0.4.24
│  └─ rollup@npm:2.78.0 (via npm:^2.77.3)
│
├─ unbuild@npm:0.8.8
│  └─ rollup@npm:2.78.0 (via npm:^2.77.2)
│
├─ vite@npm:3.0.7
│  └─ rollup@npm:2.77.3 (via npm:>=2.75.6 <2.77.0 || ~2.77.0)
│
└─ vite@npm:3.0.7 [daee1]
   └─ rollup@npm:2.77.3 (via npm:>=2.75.6 <2.77.0 || ~2.77.0)

(please let me know if still believe we should strictly downgrade and if it is breaking nuxt-edge with some packages require 2.78)

@pi0 pi0 closed this Aug 15, 2022
@pi0 pi0 deleted the chore/downgrade-rollup branch August 15, 2022 13:02
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants