Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi): properly detect hash and tag for upgrade changelog#6708

Merged
pi0 merged 2 commits intonuxt:mainfrom
harlan-zw:fix/nuxi-upgrade-versions
Aug 17, 2022
Merged

fix(nuxi): properly detect hash and tag for upgrade changelog#6708
pi0 merged 2 commits intonuxt:mainfrom
harlan-zw:fix/nuxi-upgrade-versions

Conversation

@harlan-zw
Copy link
Copy Markdown
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When upgrading RC versions, the Changelog link is assuming that nuxt was installed using a version with a git commit as the suffix.

For versions that don't have this, only the last digit is used, so the user gets messages like this:

ℹ Cleaning up generated nuxt files and caches...                                                                                                                                                20:39:36
ℹ Upgraded nuxt version: 3.0.0-rc.8                                                                                                                                                         20:39:36
✔ Successfully upgraded nuxt from 3.0.0-rc.6 to 3.0.0-rc.8                                                                                                                                    20:39:36
ℹ Changelog: https://github.com/nuxt/framework/compare/6...8

This PR fixes the behaviour and links the changelog correctly.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 17, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 27ec988
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62fcd64df7385100087a04b0

Comment thread packages/nuxi/src/commands/upgrade.ts Outdated
@pi0 pi0 changed the title fix(nuxi): changelog link to handle hash's and tags fix(nuxi): properly detect hash and tag for upgrade changelog Aug 17, 2022
@pi0 pi0 merged commit 99c960f into nuxt:main Aug 17, 2022
@pi0 pi0 mentioned this pull request Aug 26, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants