Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

Modify pages/index.vue and content#6861

Closed
HomWang wants to merge 1 commit intonuxt:mainfrom
HomWang:patch-11
Closed

Modify pages/index.vue and content#6861
HomWang wants to merge 1 commit intonuxt:mainfrom
HomWang:patch-11

Conversation

@HomWang
Copy link
Copy Markdown
Contributor

@HomWang HomWang commented Aug 23, 2022

Add tsx and template, and change the content to Welcome to nuxt3

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Add `tsx` and `template`, and change the content to `Welcome to nuxt3`
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 23, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit ab3f8cb
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6304377db3222500081dc961
😎 Deploy Preview https://deploy-preview-6861--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to be careful using to give JSX examples anywhere but in the advanced or examples sections. Here's a section from the Vue docs:

Vue recommends using templates to build applications in the vast majority of cases. However, there are situations where we need the full programmatic power of JavaScript. That's where we can use the render function.

https://vuejs.org/guide/extras/render-function.html#render-functions-jsx

@HomWang
Copy link
Copy Markdown
Contributor Author

HomWang commented Aug 23, 2022

I think we want to be careful using to give JSX examples anywhere but in the advanced or examples sections. Here's a section from the Vue docs:

Vue recommends using templates to build applications in the vast majority of cases. However, there are situations where we need the full programmatic power of JavaScript. That's where we can use the render function.
https://vuejs.org/guide/extras/render-function.html#render-functions-jsx

Okey. maybe i am a tsx paranoid

@HomWang HomWang closed this Aug 23, 2022
@danielroe
Copy link
Copy Markdown
Member

Understood! I still think it's worth documenting, but maybe in an example, or in an advanced section?

@HomWang
Copy link
Copy Markdown
Contributor Author

HomWang commented Aug 23, 2022

This example should appear in the vue.js document, but unfortunately I checked all the information, it seems that there is no. I think it's very useful because it provides tsx and template Flexibility to mix and match. I don't know if you like this usage

@pi0
Copy link
Copy Markdown
Member

pi0 commented Aug 23, 2022

This example should appear in the vue.js document, but unfortunately I checked all the information, it seems that there is no

Indeed. This is because supporting .tsx is not official for Vue.js - while possible -. We could have an example in examples/ directory to show how it works.

@HomWang
Copy link
Copy Markdown
Contributor Author

HomWang commented Aug 23, 2022

We could have an example in examples/ directory to show how it works.

Which directory should it be in examples/?

@pi0
Copy link
Copy Markdown
Member

pi0 commented Aug 23, 2022

examples/advanced/tsx i would suggest :)

@HomWang
Copy link
Copy Markdown
Contributor Author

HomWang commented Aug 23, 2022

examples/advanced/tsx i would suggest :)

Great. I've already figured out how to write it. There should be components and pages, and various ways to use TSX

@HomWang HomWang mentioned this pull request Aug 23, 2022
7 tasks
@HomWang
Copy link
Copy Markdown
Contributor Author

HomWang commented Aug 23, 2022

Link: #6870

@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants