Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): lazy composables shouldn't block setup in ssr: false#6901

Merged
pi0 merged 1 commit intomainfrom
fix/lazy-spa
Aug 24, 2022
Merged

fix(nuxt): lazy composables shouldn't block setup in ssr: false#6901
pi0 merged 1 commit intomainfrom
fix/lazy-spa

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Looks like we weren't covering the condition of ssr: false & lazy: true. Reported in chat.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Aug 24, 2022
@danielroe danielroe requested a review from pi0 August 24, 2022 12:43
@danielroe danielroe self-assigned this Aug 24, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 24, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 5ccd397
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63061d0e780c160008733e4d
😎 Deploy Preview https://deploy-preview-6901--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0
Copy link
Copy Markdown
Member

pi0 commented Aug 24, 2022

@danielroe Can you please kindly make a reproduction?

@danielroe
Copy link
Copy Markdown
Member Author

danielroe commented Aug 24, 2022

@pi0 pi0 merged commit 403e0e6 into main Aug 24, 2022
@pi0 pi0 deleted the fix/lazy-spa branch August 24, 2022 19:05
@pi0 pi0 mentioned this pull request Aug 26, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants