Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): remove client manifest.json from public dir#7021

Merged
pi0 merged 2 commits intomainfrom
fix/client-manifest
Aug 29, 2022
Merged

fix(vite): remove client manifest.json from public dir#7021
pi0 merged 2 commits intomainfrom
fix/client-manifest

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves nuxt/nuxt#14733

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently, vite manifest gets accidentally included in public assets dir. It is not used and the data within it is incorrect (i.e. non-normalised)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Aug 29, 2022
@danielroe danielroe requested a review from pi0 August 29, 2022 08:58
@danielroe danielroe self-assigned this Aug 29, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 29, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 53cb044
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/630c884d02ce6400098a49a5

Comment thread packages/vite/src/manifest.ts Outdated
@pi0 pi0 merged commit af2835f into main Aug 29, 2022
@pi0 pi0 deleted the fix/client-manifest branch August 29, 2022 09:37
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

client manifest is included in public/

2 participants