This repository was archived by the owner on Apr 6, 2023. It is now read-only.
Merged
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
danielroe
reviewed
Aug 30, 2022
| } as AsyncData<DataT, DataE> | ||
| // Create or use a shared asyncData entity | ||
| if (!nuxt._asyncData[key]) { | ||
| nuxt._asyncData[key] = { |
Member
There was a problem hiding this comment.
@pi0 Have you checked whether this retains reactivity if this is created outside a component setup (eg in plugin), or when it is used after the original component that created it has unmounted?
Member
Author
There was a problem hiding this comment.
You can try it (as mentioned in the description we need to iterate over to fix the related issue).
BTW really the use case of useAsyncData is to be used within the component lifecycle, not the plugins even if partially possible.
Good point about reactivity after unmounting. Will test this.
7 tasks
This was referenced Aug 30, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/nuxt#13910 #5078 #5738
❓ Type of change
📚 Description
With the initial implementation of
useAyncData, we were using a shared promise to avoid running two asyncData promises with the same key at the same time but the fetching state and data was not shared. It makes problems if someone tries to make a higher-order composable that returns a new instance of asyncData with the same key.This PR resolves it using a shared
_asyncDatamap in nuxtApp interface also adding tests from #5738 by @OhB00.Remarks:
We probably can iterate over this. Normally each useAsyncData should be unique based on its key and a factory pattern shall be introduced for
createAsyncDataandcreateFetch(discussion: nuxt/nuxt#14736)I will follow up with more PRs to have proper changelog.
📝 Checklist