Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi): pass value of https through to vite-node#7271

Merged
pi0 merged 2 commits intomainfrom
fix/dev-https
Sep 6, 2022
Merged

fix(nuxi): pass value of https through to vite-node#7271
pi0 merged 2 commits intomainfrom
fix/dev-https

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves nuxt/nuxt#14783

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR passes the value of https through to vite-node (which was reading it). Note that if users are using a self-signed certificate then they will also need to set NODE_TLS_REJECT_UNAUTHORIZED=0, for example:

NODE_TLS_REJECT_UNAUTHORIZED=0 yarn dev --https --ssl-cert localhost.pem --ssl-key localhost-key.pem

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 6, 2022
@danielroe danielroe requested a review from pi0 September 6, 2022 09:21
@danielroe danielroe self-assigned this Sep 6, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 6, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 58b2aa9
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63171117f0497e00091cb67c
😎 Deploy Preview https://deploy-preview-7271--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage vite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

https for dev-server

2 participants