This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): de-default layout/component imports#7389
Merged
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
approved these changes
Sep 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#14827, resolves nuxt/nuxt#14350
❓ Type of change
📚 Description
When we were producing a single inlined file, we were not de-defaulting the exports.
So, for example, a default layout ended up resolving to
{ default: /* layout */ }, triggering a warning from vue that it had no render property. (The actual render property could have been accessed onlayout.default.render.)This completely broke all inlined targets (cloudflare, vercel-edge, netlify-edge) if you were using layouts or lazy components.
Adding interop defaults resolves the issue. I've gone ahead and done the same for lazy components and custom error components which were not mentioned in the original report, but had the same buggy behaviour in my testing.
Middleware doesn't need it as it is de-defaulted at point of use.
📝 Checklist