Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

docs(api): add useRuntimeConfig page#7406

Merged
pi0 merged 5 commits intonuxt:mainfrom
Krutie:docs/api-components-use-runtime-config
Sep 12, 2022
Merged

docs(api): add useRuntimeConfig page#7406
pi0 merged 5 commits intonuxt:mainfrom
Krutie:docs/api-components-use-runtime-config

Conversation

@Krutie
Copy link
Copy Markdown
Contributor

@Krutie Krutie commented Sep 10, 2022

🔗 Linked issue nuxt/nuxt#13653

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added API documentation for useRuntimeConfig composable

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 10, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit fef649c
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/631f09f54d6fbc00082fe714
😎 Deploy Preview https://deploy-preview-7406--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@DamianGlowala DamianGlowala self-requested a review September 10, 2022 22:50
Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! A few suggestions

Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
@pi0 pi0 self-assigned this Sep 12, 2022
@pi0 pi0 force-pushed the docs/api-components-use-runtime-config branch from 3bf0db3 to 8680426 Compare September 12, 2022 10:08
@pi0
Copy link
Copy Markdown
Member

pi0 commented Sep 12, 2022

Thanks so much for adding more api pages 💯 I have made few refactors to split the app and environment variables section.

@danielroe Would you please double check my last refactor to add back any missing comment?

Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
Comment thread docs/content/3.api/1.composables/use-runtime-config.md Outdated
@pi0 pi0 merged commit 9f1ac4f into nuxt:main Sep 12, 2022
This was referenced Sep 14, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants