Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): only delete assets when building#7486

Merged
pi0 merged 1 commit intomainfrom
fix/delete-build
Sep 13, 2022
Merged

fix(nuxt): only delete assets when building#7486
pi0 merged 1 commit intomainfrom
fix/delete-build

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When noScripts is enabled, we would end up deleting the entry file within node_modules (as it is now fully resolved) 🤦.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🔥 p5-urgent Priority 5: build-breaking bugs that affect most users and should be fixed ASAP labels Sep 13, 2022
@danielroe danielroe requested a review from pi0 September 13, 2022 21:42
@danielroe danielroe self-assigned this Sep 13, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 13, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit d27eb2c
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6320f95e5d0c350008d717bf

@pi0 pi0 merged commit 40d0907 into main Sep 13, 2022
@pi0 pi0 deleted the fix/delete-build branch September 13, 2022 21:57
This was referenced Sep 14, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔥 p5-urgent Priority 5: build-breaking bugs that affect most users and should be fixed ASAP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants