This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): disable payload extraction for spa generated pages#7535
Merged
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
danielroe
reviewed
Sep 15, 2022
Member
danielroe
left a comment
There was a problem hiding this comment.
Looks good to me. Unless we can imagine a nitro plugin injecting initial info into a payload?
What about checking whether there is content in the payload?
Member
Author
That is still considered the initial state of the page. What we extract to the If Nitro plugins extend anything in the payload, it will be ignored by SPA renderer (following up with another PR to change it). But this is a rare and new usecase for prerendering spa with payload support. |
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
https://github.com/nuxt/framework/discussions/7513#discussioncomment-3649155
❓ Type of change
📚 Description
SPA pages have no actual payload data (other than initial state).
This also fixes issue for special spa (
index.html,200.htmland404.html) routes.📝 Checklist