Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): strip non-.vue extensions from component types #7673

Merged
pi0 merged 1 commit into from
Sep 20, 2022
Merged

fix(nuxt): strip non-.vue extensions from component types #7673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/nuxt/src/components/templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ export const componentsTypeTemplate: NuxtTemplate<ComponentsTemplateContext> = {
const buildDir = nuxt.options.buildDir
const componentTypes = options.getComponents().map(c => [
c.pascalName,
`typeof ${genDynamicImport(isAbsolute(c.filePath) ? relative(buildDir, c.filePath) : c.filePath, { wrapper: false })}['${c.export}']`
`typeof ${genDynamicImport(isAbsolute(c.filePath)
Copy link
Copy Markdown
Member

@pi0 pi0 Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor: We could introduce genTypeImport / genDynamicTypeImport that generates extension stripped imports and option for exception.

Copy link
Copy Markdown
Member

@pi0 pi0 Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~> unjs/knitwork#24

? relative(buildDir, c.filePath).replace(/(?<=\w)\.(?!vue)\w+$/g, '')
: c.filePath.replace(/(?<=\w)\.(?!vue)\w+$/g, ''), { wrapper: false })}['${c.export}']`
])

return `// Generated by components discovery
Expand Down