Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): respect immediate option in useFetch#7720

Merged
pi0 merged 1 commit intomainfrom
fix/immediate-fetch
Sep 22, 2022
Merged

fix(nuxt): respect immediate option in useFetch#7720
pi0 merged 1 commit intomainfrom
fix/immediate-fetch

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves nuxt/nuxt#14982

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We were not passing immediate from useFetch -> useAsyncData.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 21, 2022
@danielroe danielroe requested a review from pi0 September 21, 2022 11:09
@danielroe danielroe self-assigned this Sep 21, 2022
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Sep 21, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 21, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit ca97b3f
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/632af0e37051f4000857e38d
😎 Deploy Preview https://deploy-preview-7720--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0 pi0 merged commit 2894a75 into main Sep 22, 2022
@pi0 pi0 deleted the fix/immediate-fetch branch September 22, 2022 13:55
@danielroe danielroe mentioned this pull request Oct 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useFetch() option immediate = false does't not stop the request from being made immediately

2 participants