Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

docs(navigate-to): use await instead of return#7734

Merged
atinux merged 2 commits intonuxt:mainfrom
TheDutchCoder:main
Sep 22, 2022
Merged

docs(navigate-to): use await instead of return#7734
atinux merged 2 commits intonuxt:mainfrom
TheDutchCoder:main

Conversation

@TheDutchCoder
Copy link
Copy Markdown
Contributor

@TheDutchCoder TheDutchCoder commented Sep 21, 2022 •
edited by danielroe
Loading

🔗 Linked issue

resolves nuxt/nuxt#15002

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  1. Changes the navigateTo example to use await instead of return, as return will throw a compilation error.
  2. Formats the block of code to be consistent with other blocks.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Sep 21, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 21, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 7b4db06
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/632b65b569fb570009f9d165
😎 Deploy Preview https://deploy-preview-7734--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@TheDutchCoder TheDutchCoder changed the title docs: 📝 Use await instead of return docs(navigate-to): Use await instead of return Sep 21, 2022
@TheDutchCoder TheDutchCoder changed the title docs(navigate-to): Use await instead of return docs(navigate-to): use await instead of return Sep 21, 2022
DamianGlowala
DamianGlowala suggested changes Sep 21, 2022
View reviewed changes
Comment thread docs/content/3.api/3.utils/navigate-to.md Outdated
danielroe
danielroe approved these changes Sep 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@danielroe danielroe added the documentation Improvements or additions to documentation label Sep 22, 2022
@atinux atinux merged commit f4f6ed4 into nuxt:main Sep 22, 2022
@danielroe danielroe mentioned this pull request Oct 9, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@danielroe danielroe danielroe approved these changes

@DamianGlowala DamianGlowala DamianGlowala approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

navigateTo examples throw errors

4 participants

@TheDutchCoder @danielroe @DamianGlowala @atinux