This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): don't disable scripts in dev mode with experimental noScripts#7745
Merged
fix(nuxt): don't disable scripts in dev mode with experimental noScripts#7745
noScripts#7745Conversation
|
|
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
|
Doesn't it make sense to have consistent behavior between dev and prod for disabling scripts? |
Member
Author
|
We are testing for dev here: framework/packages/nuxt/src/core/nuxt.ts Line 95 in 5605f1c I think HMR for dev, but no scripts for built site seems a better default, but happy to be convinced otherwise. |
pi0
approved these changes
Sep 26, 2022
noScripts
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#15000
❓ Type of change
📚 Description
We should only respect
experimental.noScriptsin built mode.📝 Checklist