Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): don't disable scripts in dev mode with experimental noScripts#7745

Merged
pi0 merged 1 commit intomainfrom
fix/dev-no-scripts
Sep 26, 2022
Merged

fix(nuxt): don't disable scripts in dev mode with experimental noScripts#7745
pi0 merged 1 commit intomainfrom
fix/dev-no-scripts

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves nuxt/nuxt#15000

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We should only respect experimental.noScripts in built mode.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Sep 22, 2022
@danielroe danielroe requested a review from pi0 September 22, 2022 08:08
@danielroe danielroe self-assigned this Sep 22, 2022
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Sep 22, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 22, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 57c7382
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/632c17e8f3a2610008869926
😎 Deploy Preview https://deploy-preview-7745--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0
Copy link
Copy Markdown
Member

pi0 commented Sep 22, 2022

Doesn't it make sense to have consistent behavior between dev and prod for disabling scripts?

@danielroe
Copy link
Copy Markdown
Member Author

We are testing for dev here:

if (nuxt.options.experimental.noScripts && !nuxt.options.dev) {

I think HMR for dev, but no scripts for built site seems a better default, but happy to be convinced otherwise.

@pi0 pi0 changed the title fix(nuxt): don't disable scripts in dev mode fix(nuxt): don't disable scripts in dev mode with experimental noScripts Sep 26, 2022
@pi0 pi0 merged commit 4c50488 into main Sep 26, 2022
@pi0 pi0 deleted the fix/dev-no-scripts branch September 26, 2022 09:52
@danielroe danielroe mentioned this pull request Oct 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Experemental noScripts

2 participants