Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): prevent overlap between vite assets and app routes#7989

Merged
danielroe merged 1 commit intomainfrom
fix/vite-base-workaround
Oct 11, 2022
Merged

fix(vite): prevent overlap between vite assets and app routes#7989
danielroe merged 1 commit intomainfrom
fix/vite-base-workaround

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves nuxt/nuxt#15052

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

As is, /app will render /app.vue. (The base config option is completely ignored - and in fact removed by vite - so no need to do the same ourselves.) A workaround is to inject and remove a random string to bypass matching vite-handled paths.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Oct 4, 2022
@danielroe danielroe requested a review from antfu October 4, 2022 18:34
@danielroe danielroe self-assigned this Oct 4, 2022
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Oct 4, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 4, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 550b4db
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/633c7cad0e4fdb00082febd7

@vercel vercel Bot temporarily deployed to Preview October 4, 2022 18:34 Inactive
@danielroe danielroe requested a review from atinux October 9, 2022 19:56
@danielroe danielroe mentioned this pull request Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage vite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/app renders app.vue in development

3 participants