Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

types: include nuxt-link target types#8172

Merged
pi0 merged 2 commits intonuxt:mainfrom
vencho-mdp:patch-1
Oct 13, 2022
Merged

types: include nuxt-link target types#8172
pi0 merged 2 commits intonuxt:mainfrom
vencho-mdp:patch-1

Conversation

@vencho-mdp
Copy link
Copy Markdown
Contributor

@vencho-mdp vencho-mdp commented Oct 13, 2022

🔗 Linked issue

resolves nuxt/nuxt#15148

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added possible types for target value, in order to provide autocompletion.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Oct 13, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 13, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit e478039
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/634831ae2289090008c3403a

Comment thread packages/nuxt/src/app/components/nuxt-link.ts Outdated
Co-authored-by: Daniel Roe <daniel@roe.dev>
Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@pi0 pi0 merged commit 9fa147d into nuxt:main Oct 13, 2022
@vencho-mdp vencho-mdp deleted the patch-1 branch October 13, 2022 21:15
@pi0 pi0 mentioned this pull request Oct 18, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autocompletion for the target attribute of the <NuxtLink> component

4 participants