This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): avoid head dom update on same route click#8206
Conversation
|
|
✅ Deploy Preview for nuxt3-docs canceled.
|
harlan-zw
changed the title
danielroe
approved these changes
Oct 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#15159
❓ Type of change
📚 Description
There are two issues present:
childrenis being reset before the dom re-render. Fixed here: fix: ensure tags props are immutable vueuse/head#139 and is available the latest @vueuse/head RC (have bumped in this PR)Have confirmed that either of these fixes the issue in this test.
📝 Checklist