Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

refactor(nuxt): use h3 early hints util#8245

Merged
pi0 merged 3 commits intomainfrom
refactor/h3-hint
Oct 17, 2022
Merged

refactor(nuxt): use h3 early hints util#8245
pi0 merged 3 commits intomainfrom
refactor/h3-hint

Conversation

@danielroe
Copy link
Copy Markdown
Member

@danielroe danielroe commented Oct 17, 2022

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This uses new h3 writeEarlyHints util: h3js/h3#184

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing label Oct 17, 2022
@danielroe danielroe requested a review from pi0 October 17, 2022 09:02
@danielroe danielroe self-assigned this Oct 17, 2022
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Oct 17, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 17, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 92228e2
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/634d1b23b9b3560007d01dc5

pi0
pi0 reviewed Oct 17, 2022
View reviewed changes
Comment thread packages/nuxt/src/core/runtime/nitro/renderer.ts Outdated
@danielroe @pi0
fix: remove check
92228e2 
Co-authored-by: pooya parsa <pyapar@gmail.com>
@pi0 pi0 merged commit 9388e65 into main Oct 17, 2022
@pi0 pi0 deleted the refactor/h3-hint branch October 17, 2022 09:16
@pi0 pi0 mentioned this pull request Oct 18, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@pi0 pi0 pi0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danielroe danielroe

Labels

3.x 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe @pi0