Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): avoid preloading external routes#8255

Merged
pi0 merged 1 commit intomainfrom
fix/preload-external
Oct 17, 2022
Merged

fix(nuxt): avoid preloading external routes#8255
pi0 merged 1 commit intomainfrom
fix/preload-external

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

regression from #8225 - we should avoid using router.resolve on routes we know are external.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Oct 17, 2022
@danielroe danielroe requested a review from pi0 October 17, 2022 15:00
@danielroe danielroe self-assigned this Oct 17, 2022
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Oct 17, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 17, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 50c4baf
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/634d6e1db9aa6400086812e4

@pi0 pi0 merged commit a90b303 into main Oct 17, 2022
@pi0 pi0 deleted the fix/preload-external branch October 17, 2022 17:54
@pi0 pi0 mentioned this pull request Oct 18, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants