Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

Fixed cookie value type#8754

Closed
magyarb wants to merge 1 commit intonuxt:mainfrom
magyarb:patch-1
Closed

Fixed cookie value type#8754
magyarb wants to merge 1 commit intonuxt:mainfrom
magyarb:patch-1

Conversation

@magyarb
Copy link
Copy Markdown
Contributor

@magyarb magyarb commented Nov 6, 2022

Discussed in https://github.com/nuxt/framework/discussions/2576

The cookie.value is typed as string, so // @ts-ignore must be used to do this. I have fixed the types, so the cookie can be deleted without a ts error.

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

### Discussed in https://github.com/nuxt/framework/discussions/2576

The cookie.value is typed as string, so // @ts-ignore must be used to do this. I have fixed the types, so the cookie can be deleted without a ts error.
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 6, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit cc1df3e
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636825990b9cf90008354d52
😎 Deploy Preview https://deploy-preview-8754--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Nov 6, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe
Copy link
Copy Markdown
Member

I've made a new PR to make a couple changes - see #8769. Feel free to merge them back into this PR if you would like - and in future please allow maintainers edit access to your PRs.

@danielroe danielroe self-assigned this Nov 7, 2022
@pi0
Copy link
Copy Markdown
Member

pi0 commented Nov 9, 2022

Merged via #8769. Thanks for PR ❤️

@pi0 pi0 closed this Nov 9, 2022
@magyarb magyarb deleted the patch-1 branch November 14, 2022 15:57
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants