Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt-link): add isExternal to slot props#8800

Merged
pi0 merged 5 commits intonuxt:mainfrom
TheAlexLichter:feat/nuxt-linkadd-is-external
Nov 9, 2022
Merged

feat(nuxt-link): add isExternal to slot props#8800
pi0 merged 5 commits intonuxt:mainfrom
TheAlexLichter:feat/nuxt-linkadd-is-external

Conversation

@TheAlexLichter
Copy link
Copy Markdown
Member

🔗 Linked issue

nuxt/nuxt#15398

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR exposes the isExternal scoped slot prop of <NuxtLink>

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Nov 8, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 8, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit b89549d
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636a25e0d7e5270008ad225e

Comment thread packages/nuxt/src/app/components/nuxt-link.ts Outdated
Co-authored-by: Daniel Roe <daniel@roe.dev>
Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@pi0 pi0 merged commit 15d4cea into nuxt:main Nov 9, 2022
@TheAlexLichter TheAlexLichter deleted the feat/nuxt-linkadd-is-external branch November 9, 2022 09:35
@pi0 pi0 mentioned this pull request Nov 15, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants