This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(ssr): ensure useRequestHeaders are case-insensitive#8805
Merged
Conversation
|
|
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
aaharu
reviewed
Nov 8, 2022
Member
Author
|
Oh well, that was easy. Thanks @danielroe (Before merging, please ensure to add Co-Authored-by to credit @aaharu for the finding 🙏🏻) |
pi0
approved these changes
Nov 9, 2022
Member
pi0
left a comment
pi0
left a comment
There was a problem hiding this comment.
LGTM. We might also update this utility with new h3.useRequestHeaders that does the normalization
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
https://github.com/nuxt/framework/discussions/8803
❓ Type of change
📚 Description
Makes headers case-insensitive.
Would be good to double-check if headers always come lower-cased from the server. If no, maybe add a transform step there too.
https://github.com/unjs/h3/blob/6beee463d0e95207480acfd21badc2c2fa46f6c3/src/utils/request.ts#L58-L65 does not handle casing. Should I create a PR or an issue there too?
📝 Checklist