Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): do not render page if we are throwing error#8821

Merged
pi0 merged 1 commit intomainfrom
fix/router-abort
Nov 9, 2022
Merged

fix(nuxt): do not render page if we are throwing error#8821
pi0 merged 1 commit intomainfrom
fix/router-abort

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves nuxt/nuxt#15407

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This ensures that we do not go on to render the page if we are going to be throwing an error or returning a redirect.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Nov 8, 2022
@danielroe danielroe requested a review from pi0 November 8, 2022 16:50
@danielroe danielroe self-assigned this Nov 8, 2022
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Nov 8, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 8, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 8801fca
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636a88f5c61c3b000a136e76

@pi0 pi0 merged commit 5a32927 into main Nov 9, 2022
@pi0 pi0 deleted the fix/router-abort branch November 9, 2022 09:08
@pi0 pi0 mentioned this pull request Nov 15, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Component setup runs before router middleware is resolved

2 participants