Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): allow directly rendering error page in dev#8850

Closed
danielroe wants to merge 1 commit intomainfrom
fix/error-dev-protection
Closed

fix(nuxt): allow directly rendering error page in dev#8850
danielroe wants to merge 1 commit intomainfrom
fix/error-dev-protection

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves nuxt/nuxt#15362

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We likely only need to protect against directly rendering the error page in production; this seems to cause issues in dev mode as it is triggered by vite-node errors.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Nov 9, 2022
@danielroe danielroe requested a review from pi0 November 9, 2022 11:22
@danielroe danielroe self-assigned this Nov 9, 2022
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Nov 9, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 9, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 9d52d30
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636b8d750e200600099447ba

@danielroe danielroe marked this pull request as draft November 9, 2022 13:32
@pi0
Copy link
Copy Markdown
Member

pi0 commented Nov 10, 2022

Adding a direct render call was actually to fix an issue with the development template XSS only. #8884 should fixed linked issue.

@pi0 pi0 closed this Nov 10, 2022
@pi0 pi0 deleted the fix/error-dev-protection branch November 10, 2022 11:39
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No response returned from render handler [upgraded from RC.12 to 13]

2 participants