Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): avoid passing attrs to default slot for ClientOnly#8921

Merged
pi0 merged 1 commit intonuxt:mainfrom
huang-julien:fix/clientOnly-attrs
Nov 14, 2022
Merged

fix(nuxt): avoid passing attrs to default slot for ClientOnly#8921
pi0 merged 1 commit intonuxt:mainfrom
huang-julien:fix/clientOnly-attrs

Conversation

@huang-julien
Copy link
Copy Markdown
Member

🔗 Linked issue

resolve nuxt/nuxt#15444

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hi 👋, this PR remove the attributes inheritance from <ClientOnly>. It was causing a [Vue warn]: Extraneous non-props attributes (class) were passed to component but could not be automatically inherited because component renders fragment or text root nodes. warn log in console in dev

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Nov 11, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 11, 2022

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 82400fc
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636e8166b3a56c0008cd3c3f
😎 Deploy Preview https://deploy-preview-8921--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe danielroe requested a review from pi0 November 11, 2022 18:32
@danielroe danielroe added bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Nov 11, 2022
@pi0 pi0 merged commit 8c4ff5c into nuxt:main Nov 14, 2022
@pi0
Copy link
Copy Markdown
Member

pi0 commented Nov 14, 2022

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🔨 p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClientOnly attrs are passed to the default slot

3 participants