[#4403][refactor] Move match_moe, sharding, load_weights to modular inference optimizer - #124
Merged
h-guo18 merged 7 commits intoAug 10, 2025
Conversation
|
Could you also run the full unit tests |
Fridah-nv
reviewed
Aug 7, 2025
Fridah-nv
reviewed
Aug 7, 2025
Fridah-nv
reviewed
Aug 7, 2025
Fridah-nv
reviewed
Aug 7, 2025
Fridah-nv
reviewed
Aug 7, 2025
|
@greg-kwasniewski1 could you also take a look at changes for sharding transformations? |
h-guo18
changed the base branch from
feat/ad-arch-2025-08-01
to
user/fridah/merge-0801
August 8, 2025 23:36
h-guo18
force-pushed
the
haoguo/move_moe_sharding_loadweights
branch
from
August 9, 2025 01:10
b220110 to
e90aadb
Compare
Fridah-nv
force-pushed
the
user/fridah/merge-0801
branch
2 times, most recently
from
August 9, 2025 02:30
50199c5 to
30cd46e
Compare
…nf optimizer Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
… optimizer Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
…mports; Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
h-guo18
force-pushed
the
haoguo/move_moe_sharding_loadweights
branch
from
August 10, 2025 01:27
e90aadb to
de5d0aa
Compare
Fridah-nv
pushed a commit
that referenced
this pull request
Aug 11, 2025
…ular inference optimizer (#124) * refactor: move match_moe_pattern, sharding, load_weights to modular inf optimizer Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * refactor: move match_moe, sharding, load_weights to modular inference optimizer Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * style: fix typo; remove redundant comments Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * polish: keep moe skip test; move sharding configs to avoid circular imports; Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * remove redundant comments Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * style: rename class name Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * fix quant_graph inputs; add type hints for shared_config Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> --------- Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Fridah-nv
pushed a commit
that referenced
this pull request
Aug 11, 2025
…ular inference optimizer (#124) * refactor: move match_moe_pattern, sharding, load_weights to modular inf optimizer Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * refactor: move match_moe, sharding, load_weights to modular inference optimizer Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * style: fix typo; remove redundant comments Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * polish: keep moe skip test; move sharding configs to avoid circular imports; Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * remove redundant comments Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * style: rename class name Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * fix quant_graph inputs; add type hints for shared_config Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> --------- Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Fridah-nv
pushed a commit
that referenced
this pull request
Aug 11, 2025
…ular inference optimizer (#124) * refactor: move match_moe_pattern, sharding, load_weights to modular inf optimizer Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * refactor: move match_moe, sharding, load_weights to modular inference optimizer Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * style: fix typo; remove redundant comments Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * polish: keep moe skip test; move sharding configs to avoid circular imports; Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * remove redundant comments Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * style: rename class name Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> * fix quant_graph inputs; add type hints for shared_config Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com> --------- Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
Refactor: added shared configs in Inference Optimizer for configs shared by multiple transforms
Move transforms: match_moe, sharding, laod_weights to new inf optimizer
Test Coverage
Unit tests
pytest tests/unittest/_torch/auto_deploy/unit/852 passed, 37 skipped, 49 xfailed, 4 xpassed, 31 warnings in 715.34s (0:11:55)TRT-bench
with modifications, tp=1:
target branch, tp=1:
with modifications, tp=2:
target branch, tp=2:
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.