[https://nvbugs/5527956][fix] AutoDeploy: fix IMA due to outdated metadata - #140
Merged
Merged
Conversation
…es with better reset/sizing Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in AutoDeploy where outdated metadata was causing problems with IMA (Inflight Batching Attention). The changes primarily focus on improving cache management, parameter validation, and logging consistency.
- Updates KV cache resizing logic to use more specific cache name matching
- Improves parameter handling for max_num_tokens and cache page calculations
- Adds better error checking and logging for cache operations
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| kvcache.py | Removes exception handling around cache resizing and unused logger import |
| cleanup_input_constraints.py | Adds heuristic multiplier to constraint calculations for safety margin |
| interface.py | Updates cache name matching to be more specific (k_cache/v_cache vs generic "cache") |
| ad_executor.py | Removes redundant logging statement |
| attention_interface.py | Improves max_num_tokens parameter handling, page calculation logic, and adds validation checks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lucaslie
added a commit
that referenced
this pull request
Sep 29, 2025
…es with better reset/sizing (#140) Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
nvchenghaoz
pushed a commit
that referenced
this pull request
Oct 1, 2025
…es with better reset/sizing (#140) Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
nvchenghaoz
pushed a commit
that referenced
this pull request
Oct 3, 2025
…es with better reset/sizing (#140) Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-picked from NVIDIA#8002