[AutoDeploy] more robust handling of attention interface and input nodes - #31
Merged
Conversation
Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
lucaslie
force-pushed
the
ll/attn_if_updated
branch
from
May 23, 2025 03:45
952a715 to
8875b5a
Compare
lucaslie
added a commit
that referenced
this pull request
May 23, 2025
…33) * Add Phi3.5-mini patch and revert gemm_fusion change (rebased) (#28) * add phi3.5 patch Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * revert gemm fusion change Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * update README Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> --------- Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * [AutoDeploy] correct random init (#30) Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * [AutoDeploy] more robust handling of attention interface and input nodes (#31) * [AutoDeploy] more robust handling of attention interface and input nodes Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * updated description for AttentionInterface Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> --------- Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * Several Bug Fix: bias missing for linear/lift canonicalize_graph to meta device/enhance attention op args extraction (#27) * add bias patch for torch.ops.linear.simple Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * lift canonicalize_graph with shape prop to meta device Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * fix attention custom op default args/kwargs extract Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * add rope use case of the util file Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> --------- Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * Fix for attention argument dropout_p='None' (#29) * updated attention args logic tp handle case in which default values for dropout_p is not captured by the graph Signed-off-by: Suguna Velury <178320438+sugunav14@users.noreply.github.com> * Formatting fix Signed-off-by: Suguna Velury <178320438+sugunav14@users.noreply.github.com> * Updated args assignment logic in match_causal_attn_mask Signed-off-by: Suguna Velury <178320438+sugunav14@users.noreply.github.com> --------- Signed-off-by: Suguna Velury <178320438+sugunav14@users.noreply.github.com> * [AutoDeploy] Llama-4 support + AutoModelForImageTextToText (#32) * [AutoDeploy] Llama-4 support Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * WAR: Rope Matcher Issue Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> --------- Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> --------- Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> Signed-off-by: Suguna Velury <178320438+sugunav14@users.noreply.github.com> Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com> Co-authored-by: sugunav14 <178320438+sugunav14@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lucaslie
added a commit
that referenced
this pull request
May 27, 2025
…33) * Add Phi3.5-mini patch and revert gemm_fusion change (rebased) (#28) * add phi3.5 patch Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * revert gemm fusion change Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * update README Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> --------- Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * [AutoDeploy] correct random init (#30) Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * [AutoDeploy] more robust handling of attention interface and input nodes (#31) * [AutoDeploy] more robust handling of attention interface and input nodes Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * updated description for AttentionInterface Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> --------- Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * Several Bug Fix: bias missing for linear/lift canonicalize_graph to meta device/enhance attention op args extraction (#27) * add bias patch for torch.ops.linear.simple Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * lift canonicalize_graph with shape prop to meta device Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * fix attention custom op default args/kwargs extract Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * add rope use case of the util file Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> --------- Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> * Fix for attention argument dropout_p='None' (#29) * updated attention args logic tp handle case in which default values for dropout_p is not captured by the graph Signed-off-by: Suguna Velury <178320438+sugunav14@users.noreply.github.com> * Formatting fix Signed-off-by: Suguna Velury <178320438+sugunav14@users.noreply.github.com> * Updated args assignment logic in match_causal_attn_mask Signed-off-by: Suguna Velury <178320438+sugunav14@users.noreply.github.com> --------- Signed-off-by: Suguna Velury <178320438+sugunav14@users.noreply.github.com> * [AutoDeploy] Llama-4 support + AutoModelForImageTextToText (#32) * [AutoDeploy] Llama-4 support Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * WAR: Rope Matcher Issue Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> --------- Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> --------- Signed-off-by: Ubuntu <201670829+Fridah-nv@users.noreply.github.com> Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com> Signed-off-by: Suguna Velury <178320438+sugunav14@users.noreply.github.com> Co-authored-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com> Co-authored-by: sugunav14 <178320438+sugunav14@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes and closes #4369 (was already reviewed and approved)