[#5249][AutoDeploy] Refactor the signatures of AD graph transformations to return None - #71
Merged
Merged
Conversation
Author
|
/bot run |
nzmora-nvidia
approved these changes
Jul 6, 2025
galagam
force-pushed
the
user/ghubaraagam/issue-5249
branch
from
July 6, 2025 15:24
8e433c8 to
9ee0b3b
Compare
lucaslie
approved these changes
Jul 7, 2025
lucaslie
left a comment
lucaslie
left a comment
There was a problem hiding this comment.
Please revert the changes in tensorrt_llm/_torch/compilation. Looks good to me otherwise! Thank you for updating this
Fridah-nv
reviewed
Jul 7, 2025
…VIDIA#5249) Refactor signatures of AD graph transformations from gm = transformation(gm) to transformation(gm) Since the AD graph transformations modify the input GraphModule in-place. Previous signature style was misleading. Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
galagam
force-pushed
the
user/ghubaraagam/issue-5249
branch
from
July 7, 2025 18:43
9ee0b3b to
f06b731
Compare
lucaslie
pushed a commit
that referenced
this pull request
Jul 18, 2025
…rmations to return None (#71) * Refactor the signatures of AD graph transformations to return None (NVIDIA#5249) Refactor signatures of AD graph transformations from gm = transformation(gm) to transformation(gm) Since the AD graph transformations modify the input GraphModule in-place. Previous signature style was misleading. Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
lucaslie
pushed a commit
that referenced
this pull request
Jul 21, 2025
…rmations to return None (#71) * Refactor the signatures of AD graph transformations to return None (NVIDIA#5249) Refactor signatures of AD graph transformations from gm = transformation(gm) to transformation(gm) Since the AD graph transformations modify the input GraphModule in-place. Previous signature style was misleading. Signed-off-by: Gal Hubara Agam <96368689+galagam@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor signatures of AD graph transformations from
gm = transformation(gm)
to
transformation(gm)
Since the AD graph transformations modify the input GraphModule
in-place. Previous signature style was misleading.
See also: NVIDIA#5249
Test Coverage
Refactor-only change. Using existing unit tests to verify.