[None] Add sink/sliding window support for Triton - #77
Merged
Conversation
Signed-off-by: nvchenghaoz <211069071+nvchenghaoz@users.noreply.github.com>
lucaslie
reviewed
Jul 9, 2025
Fridah-nv
reviewed
Jul 9, 2025
Signed-off-by: nvchenghaoz <211069071+nvchenghaoz@users.noreply.github.com>
Signed-off-by: nvchenghaoz <211069071+nvchenghaoz@users.noreply.github.com>
lucaslie
approved these changes
Jul 16, 2025
nvchenghaoz
enabled auto-merge (squash)
July 16, 2025 19:55
lucaslie
added a commit
that referenced
this pull request
Jul 17, 2025
lucaslie
pushed a commit
that referenced
this pull request
Jul 18, 2025
* Add sink/sliding window support for Triton Signed-off-by: nvchenghaoz <211069071+nvchenghaoz@users.noreply.github.com> * Add the test and fix the functional implementations Signed-off-by: nvchenghaoz <211069071+nvchenghaoz@users.noreply.github.com> --------- Signed-off-by: nvchenghaoz <211069071+nvchenghaoz@users.noreply.github.com>
lucaslie
added a commit
that referenced
this pull request
Jul 18, 2025
lucaslie
pushed a commit
that referenced
this pull request
Jul 21, 2025
* Add sink/sliding window support for Triton Signed-off-by: nvchenghaoz <211069071+nvchenghaoz@users.noreply.github.com> * Add the test and fix the functional implementations Signed-off-by: nvchenghaoz <211069071+nvchenghaoz@users.noreply.github.com> --------- Signed-off-by: nvchenghaoz <211069071+nvchenghaoz@users.noreply.github.com>
lucaslie
added a commit
that referenced
this pull request
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the sliding window and attention sink feature for triton backend. Also update the attention interface for these new parameters. Update tests accordingly.
Test Coverage
Update the existing test. Will add the test after the torch backend PR is merged.