[AutoDeploy] Improved config deepmerge handling - #82
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the previous Pydantic-based deep-update approach with an OmegaConf-backed deep merge utility, refactors several settings sources and factory classes to use the new helper, and expands example scripts and documentation to showcase advanced CLI and YAML configuration.
- Introduces
deep_merge_dictsusing OmegaConf for recursive merging. - Refactors
DynamicYamlWithDeepMergeSettingsSourceand settings classes to leverage the new merge logic. - Updates model factories, example scripts, and README with improved defaults, CLI dot notation, and YAML examples.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tensorrt_llm/_torch/auto_deploy/utils/_config.py | Added deep_merge_dicts and refactored YAML source to merge configs via OmegaConf. |
| tensorrt_llm/_torch/auto_deploy/models/hf.py | Reworked tokenizer/model default handling to use deep_merge_dicts. |
| tensorrt_llm/_torch/auto_deploy/models/factory.py | Simplified the register method signature. |
| tensorrt_llm/_torch/auto_deploy/llm_args.py | Migrated to Pydantic v2 settings mixin, added CLI extra-args handling. |
| tensorrt_llm/_torch/auto_deploy/config/default.yaml | Added placeholder default YAML config. |
| setup.py | Included the new YAML config files in package data. |
| examples/auto_deploy/build_and_run_ad.py | Updated example script to use OmegaConf merging and extended CLI features. |
| examples/auto_deploy/README.md | Expanded documentation with detailed CLI/YAML configuration examples. |
Comments suppressed due to low confidence (1)
tensorrt_llm/_torch/auto_deploy/config/default.yaml:2
- [nitpick] The default config file is empty but the docs reference default transform settings. Consider populating this file with the baseline defaults or clarifying that no defaults are needed.
{}
lucaslie
force-pushed
the
ll/config_deepmerging
branch
2 times, most recently
from
July 11, 2025 18:20
a6988cc to
f0e9c58
Compare
lucaslie
commented
Jul 11, 2025
lucaslie
commented
Jul 11, 2025
nvchenghaoz
approved these changes
Jul 11, 2025
Fridah-nv
reviewed
Jul 12, 2025
Fridah-nv
reviewed
Jul 12, 2025
lucaslie
force-pushed
the
ll/config_deepmerging
branch
from
July 14, 2025 18:35
f0e9c58 to
1bb0090
Compare
Fridah-nv
approved these changes
Jul 14, 2025
Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
lucaslie
force-pushed
the
ll/config_deepmerging
branch
from
July 15, 2025 19:16
1bb0090 to
f4cd863
Compare
lucaslie
added a commit
that referenced
this pull request
Jul 18, 2025
Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
lucaslie
added a commit
that referenced
this pull request
Jul 21, 2025
Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better handling of deepmerging nested configs/dictionaries from various config sources in the new config system.
Please check out the updated README section for more details on the next iteration of providing AutoDeploy configurability.