[AutoDeploy][1/n] Modular InferenceOptimizer - #84
Merged
Conversation
lucaslie
requested review from
Fridah-nv,
MrGeva,
galagam,
greg-kwasniewski1,
meenchen,
nvchenghaoz,
nzmora-nvidia and
suyoggupta
July 11, 2025 23:28
There was a problem hiding this comment.
Pull Request Overview
Introduces a modular inference optimizer pipeline by defining a high-level InferenceOptimizer class and migrating existing export and cleanup logic into discrete, configurable transforms.
- Added a
filtered_nodesutility to simplify node filtering by op type. - Replaced the legacy export flow in
transform.pywith the newModularInferenceOptimizer. - Extracted input-constraint cleanup into its own transform and cleaned up the export code accordingly.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tensorrt_llm/_torch/auto_deploy/utils/node_utils.py | Added OpOrOverload alias and new filtered_nodes utility. |
| tensorrt_llm/_torch/auto_deploy/transformations/transform.py | Switched to ModularInferenceOptimizer, removed legacy export path. |
| tensorrt_llm/_torch/auto_deploy/transformations/export.py | Removed obsolete functions and relocated aliased-param load hook. |
| tensorrt_llm/_torch/auto_deploy/transform/optimizer.py | Introduced InferenceOptimizer entrypoint and transform loop. |
| tensorrt_llm/_torch/auto_deploy/transform/library/*.py | Added new wrapper transforms (export_to_gm, build_model, cleanup_input_constraints). |
| tensorrt_llm/_torch/auto_deploy/llm_args.py | Added transforms config for the new optimizer. |
| tensorrt_llm/_torch/auto_deploy/config/default.yaml | Populated default transform configurations. |
Comments suppressed due to low confidence (1)
tensorrt_llm/_torch/auto_deploy/utils/node_utils.py:219
- [nitpick] Consider adding unit tests for
filtered_nodesto validate that it correctly yields nodes matching single and multiple ops, and skips non-matching ones.
def filtered_nodes(
lucaslie
force-pushed
the
ll/base_transformation
branch
from
July 14, 2025 18:33
e7505a3 to
62e9dd8
Compare
lucaslie
force-pushed
the
ll/config_deepmerging
branch
from
July 14, 2025 18:35
f0e9c58 to
1bb0090
Compare
Fridah-nv
reviewed
Jul 14, 2025
lucaslie
force-pushed
the
ll/config_deepmerging
branch
from
July 15, 2025 19:16
1bb0090 to
f4cd863
Compare
lucaslie
force-pushed
the
ll/base_transformation
branch
from
July 15, 2025 19:27
62e9dd8 to
174147b
Compare
nvchenghaoz
reviewed
Jul 15, 2025
Fridah-nv
reviewed
Jul 15, 2025
Fridah-nv
reviewed
Jul 15, 2025
Fridah-nv
reviewed
Jul 15, 2025
Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
lucaslie
force-pushed
the
ll/base_transformation
branch
from
July 15, 2025 21:29
174147b to
909481e
Compare
lucaslie
enabled auto-merge (squash)
July 15, 2025 21:31
lucaslie
disabled auto-merge
July 15, 2025 21:31
lucaslie
enabled auto-merge (squash)
July 15, 2025 21:32
lucaslie
added a commit
that referenced
this pull request
Jul 18, 2025
…IA#4367, NVIDIA#4366 (#84) Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
lucaslie
added a commit
that referenced
this pull request
Jul 21, 2025
…IA#4367, NVIDIA#4366 (#84) Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface and initial transforms in the new modular InferenceOptimizer design